New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dspell issues #3943

Closed
wants to merge 0 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@SinghRajenM
Contributor

SinghRajenM commented Nov 30, 2017

Issue:

  1. DspellChecker is included V7.5.2, but it is not working. Because default the dictionary path should be "%appdata%/Notepad++/plugins/config/Hunspell". Referred V6.7.8 script.

  2. To install additional language (dictionary), npp must run as admin to add these files to "%programfiles/Notepad/plugins/config/Hunspell". Therefore, better to use %adddata% instead of INSTALLDIR.

  3. Installed files are not removed on uninstallation.

Updated mainSectionFuncs.nsh, just to remove unreferenced label warning.

Please note: This PR will work after PR #3942, Because $UPDATE_PATH will be available after that only. So PR #3942 is must for this PR.

chcg referenced this pull request Dec 5, 2017

Fix installer issues
1. Fix shell extension registration error (due to notepad++.exe has not
yet been copied)
2. Fix themes' absence after installation (one variable depends on
its initialization in mainSection)

@SinghRajenM SinghRajenM closed this Dec 7, 2017

@SinghRajenM

This comment has been minimized.

Show comment
Hide comment
@SinghRajenM

SinghRajenM Dec 7, 2017

Contributor

God knows why it got closed automatically while resolving conflict.

Contributor

SinghRajenM commented Dec 7, 2017

God knows why it got closed automatically while resolving conflict.

@dail8859

This comment has been minimized.

Show comment
Hide comment
@dail8859

dail8859 Dec 7, 2017

Contributor

@SinghRajenM Looks like it was force pushed and contains 0 commits.

Contributor

dail8859 commented Dec 7, 2017

@SinghRajenM Looks like it was force pushed and contains 0 commits.

@SinghRajenM

This comment has been minimized.

Show comment
Hide comment
@SinghRajenM

SinghRajenM Dec 7, 2017

Contributor

May be. I executed below commands.

git reset --hard origin/master
git commit -a
git push --force nppSingh nsis_DspellCheck_20171130

After that It has gone. Anyway, this is already fixed by @donho in except point 2.

Contributor

SinghRajenM commented Dec 7, 2017

May be. I executed below commands.

git reset --hard origin/master
git commit -a
git push --force nppSingh nsis_DspellCheck_20171130

After that It has gone. Anyway, this is already fixed by @donho in except point 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment