Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update english.xml #511

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@bovirus
Copy link
Contributor

commented Jul 16, 2015

Update english.xml (sevral string/id missing)
There are several strings/id missing in english.xml that are instead available in translated languages and used by the program.
Please check the differencies between current and previous english.xml version..
The english.xml should be always aligned to not english language as id string.

Update english.xml
Update english.xml (sevral string/id missing)
There are several strings/id missing in english.xml that are instead available in translated languages and used by the program.
Please check the differencies between current and previous english.xml version..
The english.xml should be always aligned to not english language as id string.
@batagy

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2015

Hi!

This pull request contains wrong or incorrect suggestion.
Most of the items suggested in this pull request, were removed long time ago, or were removed intentially by Don Ho.

Please don't approve it!

For example:
"44011" name="Custom settings window..."
This is actually "44011" name = "User-Defined Dialogue...", but it was removed long time ago in 6.5 version, because the string is not needed.

"1640" name="Switch window"
This is actaully "1640" name = "Switch dialog" , but it was removed long time agon in 5.5 version, because the string is not needed.

"47004" name = "Forum"
"47008" name = "Help Contents..."
These 2 were intentionally removed by Don correctly, because of new functionalities in Notepad++ 6.7.9.2 , so these strings are not anymore used by program. So please don't add back as it would be orphane.

These were just examples, not commenting all changes in this PU.

@bovirus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2015

Thanks. Batagy.

Please take care that I made this request because, I purged some day ago the Italian language from several strings (I aligned it with English master language on Github) but the other italian translator said that there are several strings used in Italian langauge (used by program) that are not included in english master langauge.
I replied to him that if some strings is missing in Italian language and is sued into the program he should ask to developer toi include in amster english language.

OK For this strings.

"1640" name="Switch window"
"44011" name="Custom settings window..."
"47004" name = "Forum"
"47008" name = "Help Contents..."

I will remove them from english and Italian language

is not needed and should be not present in any lkanguage.

But for the others?

Did you check your language with amsetr english language?
I found several new and orphan strings in many languages.

My scope to have an english master language updatd and aligned to make a real amster for all languages.

Thanks again.

@batagy

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2015

Hi bovirus!

Yes I know of the background of your request. I answered in the Italian topic at the forum.
I also created a new topic mentioning the actually needed strings.

But for completeness here is my comments for all these changes:

Item id="43054" name="Mark..."
EDIT: This one is indeed needed, it's used. So it's valid request to add it to the master.

Item id="44011" name="Custom settings window..."
As above explained, this item is not anymore used since approx 6.5. Not needed.

Item id = "44012" name = "Hide line number margin"
Item id = "44013" name = "Hide bookmark margin"
Item id = "44014" name = "Hide folder margin"
These 3 items are only appearing in menu if "Customize Toolbar" plugin is installed. These are needed and valid.

Item id="47004" name="Forum"
Item id="47008" name="Help..."
This 2 were removed by Don Ho couple of days ago, since another method, Online chat was included instead of Help. And the Forum was removed due to this new forum. Not needed.

Item id="1640" name="Switch window"
This is not anymore used since apporx 5.5 version. Not needed.

Under StylerDialog title="Styler Dialog"
Item id = "1" name = "&OK"
Item id = "2" name = "&Cancel"
These are used and indeed missing from master. Valid.

CreateNewLanguage title="Create new language..."
Item id="1" name="OK"
Item id="2" name="Cancel"
Item id="26001" name="Name:"
/CreateNewLanguage
This window is although existing in program, but this translation is not picked up by the program, so it should not be in master.xml as it would be considered orphan. Anyway, there are also other similar windows there, like "Rename current language name" which are not translated anyway. So Not needed.

Item id="6121" name="Menu bar"
This was changed some time ago, the window was a bit reorganized in Settings. This item is not used anymore. Not needed.

Item id="6510" name="Use default value"
Item id="6510" name="Use default value"
I don't understand why you would move this string from the Tab settings into the compact Language section, because this is at the correct place. No need to change.

Item id="6257" name="bla bla bla bla bla bla"
Item id="6258" name="bla bla bla bla bla bla bla bla bla bla bla bla"
This 2 is indeed used, and missing from master English. Even thought the text can be understood probably also on other langauges. :)

Item id="6264" name="Dropbox"
Item id="6265" name="OneDrive"
Item id="6266" name="Google Drive"
This Cloud related change was done couple of days ago by Don Ho, so probably these are not anymore used. However we can't even test it since that new version of program was not yet release, I think. Not needed.

Hope is useful for you.
One general comment: please don't spam all the topics with your specific work, and don't try to force every translator bugging about how much is updated or not. I explained that in the Italian topic.

Also, think twice about suggesting changes in english.xml as it's Don Ho's reponsibility. Also, sometime including a string in english.xml alone is not enough, if the program itself doen't pick up the text. So often, program code modification is needed to add new translation. See "Create new language" example above. In this case it's better not to include it in XML. But this is completely belongs to Don. The only cases when english.xml maybe worth to update alone, when some items are in fact picked up by the program and missing. So rather ask forum first in the appropriate topic.

Regards
György

@bovirus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2015

OK:

I agree with you (but as you can see other italian trasnaltor is not agree).
I tried to explained him that NP++ 6.7.9.2 is one thing and the file on github is different.
I believe (he was the italian trasnaltor for several years and I believe that the strings that I posted before was really mssing in English language)
Anyway, could you please make a pullup request for english.,xml to add

Item id = "44012" name = "Hide line number margin"
Item id = "44013" name = "Hide bookmark margin"
Item id = "44014" name = "Hide folder margin"

In this way any translator can align and complete translation (if it needs).
Thanks. Bye.

@batagy

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2015

I have edited the 4th post since I made a mistake for below item first.

Item id="43054" name="Highlight..."
and it's actuall:
Item id="43054" name="Mark..."
This one is used, so it's needed.

@bovirus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2015

Please non consider my initial requests.
Please update master english language (confirm pull request by batagy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.