Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
WinGUP Enhancement npp #2
This PR improves WinGUP in below fashion –
@SinghRajenM (Some) Nice features! However, there may be some features which won't be accepted. In anyway this PR won't be accepted because there are at least 3 features in the same PR.
In order to make code review easier, please do one feature per PR to make your PR easier to be accepted.
Thank you for your contributions!
@donho This PR is Basically has two type of features
We have to provide commandline support if we are going to execute installer in background, because some app may use commandline other than "/S".
So if we come to code review,
So considering above points, we can say this PR actually deals with two major features.
Now, if we come to code review for these features.
Rest of code is for supporting background mode installation.
Let me know which will not be accepted, I will remove them and let us make most waited feature (background installation: I feel) happen.
@SinghRajenM For me "Provide icon for WinGUP." looks cool but it's nice to have so it depends on its complexity. The others, why not? and once again, it depends on the complexity of modification.