Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinGUP Enhancement For Npp (Revised of PR #2) #3

Conversation

Projects
None yet
2 participants
@SinghRajenM
Copy link

commented Oct 14, 2018

This PR improves WinGUP in below fashion –

  1. Provide an option to update app in background.
    a. If app is opened, then it will for app to exit.
    b. App installer must support silent installation and silent mode parameter should be added to configuration file. (e.g. /S flag which is default if flag is missing in configuration).
    c. Default silent mode (flag /S) will be used if it is missing in configuration file.
  2. Provide an option to pass commandline parameter for installer (includes both normal or silent mode paramters), this is required to support background update.
  3. Fixes small glitch of curl. In very beginning curl returns garbage value to its CURLOPT_PROGRESSFUNCTION method which turns as showing invalid download percentage (e.g. 9223372036854775808%).

donho and others added some commits Dec 14, 2017

Merge branch 'master' of https://github.com/notepad-plus-plus/wingup
…into notepad-plus-plus-master

# Conflicts:
#	src/winmain.cpp
Change logic of plugins removal/update/installation
uninstall: tell user to restart Notepad++ - Gup.exe remove all - clean in batch - relaunch Notepad++
gup.exe -clean "appPath2Launch" "dest_folder" "fold1" "a fold2" "fold3"
gup.exe -clean "c:\npp\notepad++.exe" "c:\temp\" "toto" "ti ti" "tata"

update:    tell user to restart Notepad++ - Gup.exe download - remove all in directory - unzip/clean in batch - relaunch Notepad++
gup.exe -unzip -clean  "appPath2Launch" "dest_folder" "toto http://toto" "titi http://titi" "tata http://tata"
gup.exe -unzip -clean "c:\npp\notepad++.exe" c:\temp\ "toto http://toto" "ti et ti http://titi" "tata http://tata"

Install:   GUp.exe download - create directory - unzip: one by one, no relaunch
gup.exe -unzipTo c:\donho\notepad++\plugins "https://github.com/npp-plugins/mimetools/releases/download/v2.1/mimetools.v2.1.zip"

@SinghRajenM SinghRajenM force-pushed the SinghRajenM:src_EnhanceWinGUPForNpp_Revised branch 3 times, most recently from b0582b7 to 0da587a Oct 14, 2018

@SinghRajenM SinghRajenM force-pushed the SinghRajenM:src_EnhanceWinGUPForNpp_Revised branch 2 times, most recently from 9df17d3 to 007c1d0 Oct 14, 2018

@SinghRajenM SinghRajenM force-pushed the SinghRajenM:src_EnhanceWinGUPForNpp_Revised branch from 51384b2 to 5ac19f5 Oct 14, 2018

@SinghRajenM

This comment has been minimized.

Copy link
Author

commented Oct 14, 2018

Stuck to git commands. will create new one.

@SinghRajenM SinghRajenM deleted the SinghRajenM:src_EnhanceWinGUPForNpp_Revised branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.