New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced blocking Thread.Sleep with unblocking Task.Delay #1

Merged
merged 1 commit into from Sep 8, 2013

Conversation

Projects
None yet
2 participants
@semihokur
Contributor

semihokur commented Sep 8, 2013

I am a PhD student in the CS department at the University of Illinois. I'm currently doing research on asynchronous programming in phone applications. I developed a tool that automatically improves async/await usages by doing transformations.

The tool found some opportunities in your application. You were using blocking Sleep method in an async method, causing freezing the UI. Instead, you can use nonblocking Task.Delay for the same purpose. The tool changed Sleep method with Delay method.

Are you interested in merging this pull request? If not, please let me know why.

Thanks for your time,

nothingmn added a commit that referenced this pull request Sep 8, 2013

Merge pull request #1 from semihokur/master
Replaced blocking Thread.Sleep with unblocking Task.Delay

@nothingmn nothingmn merged commit a34effd into nothingmn:master Sep 8, 2013

@nothingmn

This comment has been minimized.

Show comment
Hide comment
@nothingmn

nothingmn Sep 8, 2013

Owner

Thanks for PR!

Owner

nothingmn commented Sep 8, 2013

Thanks for PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment