Skip to content

Commits on Jul 12, 2021

  1. update version numbers

    Sean Barrett committed Jul 12, 2021

Commits on Jul 5, 2021

  1. stb_vorbis: Change imdct_step3_inner_s_loop_ld654

    Released Clang 12 generates bad code for the original loop in here.
    While this is a compiler bug plain and simple, we still have to deal
    with it.
    
    This is related to the SLP vectorizer, and in particular the two
    reverse subtracts in the butterflies for the second half to avoid
    unary negates.
    
    Use the more regular dataflow that has the unary negates in it
    (we can at least fold one of them into a constant, namely for A2)
    and introduce a few temporaries that also make alias analysis (and
    possible block-level vectorization) a whole let easier while I'm at
    it.
    
    This fixes the codegen issues on Clang 12, which now produces a
    working decoder, and I expect the single unary negate that we
    actually gain per iteration of this loop is not a significant
    perf concern. (There are bigger fish to fry here regardless.)
    
    Fixes issue #1152.
    rygorous committed Jul 5, 2021
  2. stb_vorbis: Set error on open_memory with NULL data

    "Unexpected EOF" seems like the closest match from the error
    codes we have.
    
    Fixes issue #1123.
    rygorous committed Jul 5, 2021

Commits on Jul 4, 2021

  1. stb_vorbis: Fix some unused variables.

    Fixes issue #817.
    rygorous committed Jul 4, 2021
  2. stb_vorbis: A few UB fixes.

    Fixes issue #1018.
    rygorous committed Jul 4, 2021
  3. stb_vorbis: Add missing cast to uint to avoid UB

    Fixes issue #574.
    rygorous committed Jul 4, 2021
  4. stb_vorbis: Fix unused parameter warnings.

    Some parameters do not get used, or only when certain config
    defines are set. Explicitly mark them as unused to make compilers
    happy.
    
    Fixes issue #396.
    rygorous committed Jul 4, 2021
  5. stb_vorbis: Remove spurious assignment to val

    This is definitely unnecessary, or at least I can't find anything
    in the Vorbis spec that would indicate anything special happening
    here.
    
    Fixes issue #816.
    rygorous committed Jul 4, 2021
  6. stb_vorbis: Fix memory leak in stb_vorbis

    When start_decoder() fails it may already have allocated memory
    for .vendor and/or .comment_list. Call vorbis_deinit() to free
    any allocated memory.
    
    Fixes issue #1051.
    morlad authored and rygorous committed Jul 4, 2021
  7. stb_vorbis: Move asserts around a bit

    Not an actual bug, it just looked wonky, but this code runs
    with code lengths that are verified to be in range (<32) by
    the length-reading code. Anyway.
    
    Fixes issue #901.
    rygorous committed Jul 4, 2021
  8. stb_vorbis: rename BUFFER_SIZE macro to STB_BUFFER_SIZE

    Fixes issue #1076.
    sagamusix authored and rygorous committed Jul 4, 2021

Commits on Jul 2, 2021

  1. update stb_vorbis version

    Sean Barrett committed Jul 2, 2021

Commits on Apr 13, 2021

Commits on Jan 26, 2021

Commits on Jul 13, 2020

  1. update version numbers

    Sean Barrett committed Jul 13, 2020
  2. stb_vorbis: fix bug in computing end of temp alloc buffer if it's not…

    … a multiple of 8
    Sean Barrett committed Jul 13, 2020
  3. Merge branch 'fix_stb_vorbis_alignment' of https://github.com/RandomS…

    …haper/stb into working
    Sean Barrett committed Jul 13, 2020
  4. Merge branch 'fix_alloca' of https://github.com/Clownacy/stb into wor…

    …king
    Sean Barrett committed Jul 13, 2020
  5. tweak PR

    Sean Barrett committed Jul 13, 2020
  6. add credits for last few PR merges

    Sean Barrett committed Jul 13, 2020

Commits on Apr 24, 2020

  1. Add myself to the list of contributors

    The pull-request template says to do so.
    Clownacy committed Apr 24, 2020
  2. stb_vorbis.c - Detect __NEWLIB__ for alloca.h

    This is needed for `stb_vorbis.c` to compile for the Wii U using
    devkitPro.
    
    This should theoretically also fix compilation for the Nintendo
    Switch, 3DS, and Wii (with devkitPro, that is) as they all also use
    Newlib.
    
    Newlib is also used by Cygwin:
    https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/include/alloca.h;h=5d36318914282280b353aed457e1b1f64947b584;hb=HEAD
    
    And the Google Native Client:
    https://chromium.googlesource.com/native_client/nacl-newlib/+/refs/heads/master/newlib/libc/include/alloca.h
    
    As you can see from these links, these both provide `alloca.h` as
    well, so it appears to be a safe guarantee that `alloca.h` is
    available on Newlib.
    Clownacy committed Apr 24, 2020

Commits on Mar 25, 2020

  1. Added debugging check on line 1604

    I added the code assert(f->valid_bits >= n);  instead of removing if (f->valid_bits < 0) return 0; to improve code with checking and debugging instead.
    vickit144 committed Mar 25, 2020

Commits on Mar 24, 2020

  1. Remove if (f->valid_bits < 0) return 0; on line 1603

    I propose to remove this line because  f->valid_bits will never be less than zero since, in the while loop, you're adding 8 to it. Therefore, it will always evaluate to false. This is to help remove redundant code.
    vickit144 committed Mar 24, 2020

Commits on Feb 5, 2020

  1. update version numbers

    Sean Barrett committed Feb 5, 2020
Older