Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade mio to 0.8 #386

Merged
merged 1 commit into from
Mar 1, 2022
Merged

upgrade mio to 0.8 #386

merged 1 commit into from
Mar 1, 2022

Conversation

biluohc
Copy link
Contributor

@biluohc biluohc commented Feb 28, 2022

Because tokio 1.17 already uses mio 0.8

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, glad to see that 0.8 has no pain for us :)

Copy link
Member

@0xpr03 0xpr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@0xpr03 0xpr03 merged commit b1802ec into notify-rs:main Mar 1, 2022
@complexspaces
Copy link

Tokio has also recently updated to use mio 0.8, so some of the ecosystem is looking to update to newer 1.x versions. Currently if a project has both notify and tokio in the same workspace, two versions of mio are now pulled in.

With this now merged, would it possible to publish a new pre-release if time permits?

@0xpr03
Copy link
Member

0xpr03 commented Mar 11, 2022

Yeah ping me again if I didn't publish something till sunday.

@0xpr03
Copy link
Member

0xpr03 commented Mar 13, 2022

Released once #390 is reviewed

@complexspaces
Copy link

Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants