fixup optional crossbeam feature selection in debouncer-mini #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpr03
force-pushed
the
fixup_notify_feature
branch
2 times, most recently
from
170c2e0
to
bc5d0ad
Compare
|
The bad part: if we want to name the feature |
|
CC @JohnTitor for pro/contra |
JohnTitor
reviewed
Aug 15, 2022
| default = ["crossbeam-channel"] | ||
| default = ["crossbeam"] | ||
| # can't use dep:crossbeam-channel and feature name crossbeam-channel below rust 1.60 | ||
| crossbeam = ["crossbeam-channel","notify/crossbeam-channel"] |
There was a problem hiding this comment.
Another way would be renaming our dependency like:
[dependencies]
crossbeam = { package = "crossbeam-channel", version = "..." }There was a problem hiding this comment.
But the crossbeam feature name doesn't sound that bad, so I'm fine either way :)
There was a problem hiding this comment.
oh didn't think of renaming them, but yeah I'll rename the feature in the debouncer
0xpr03
force-pushed
the
fixup_notify_feature
branch
4 times, most recently
from
7673bd0
to
ba67eae
Compare
remove printlns
0xpr03
force-pushed
the
fixup_notify_feature
branch
from
ba67eae
to
4115b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Actually pass through the optional crossbeam dep from debouncer-mini to notify.
Also verify this in CI. (Requires a manual -p call to work.)
Also closes #433