Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished first 3 algos #1

Merged
merged 5 commits into from May 3, 2019
Merged

finished first 3 algos #1

merged 5 commits into from May 3, 2019

Conversation

notontilt09
Copy link
Owner

No description provided.

@notontilt09 notontilt09 requested a review from ielvisd May 2, 2019 00:44
Copy link
Collaborator

@ielvisd ielvisd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, code is clean and concise with helpful comments. Great work Daniel.

@@ -6,7 +6,22 @@
# a solution that is more efficient than the naive
# recursive solution
def eating_cookies(n, cache=None):
pass
if n < 1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice memoized solution

@@ -6,7 +6,50 @@
Item = namedtuple('Item', ['index', 'size', 'value'])

def knapsack_solver(items, capacity):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool solution that's fast but not entirely accurate. Nice work.

@@ -3,7 +3,15 @@
import math

def recipe_batches(recipe, ingredients):
pass
multiples = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clean solution.

@ielvisd ielvisd merged commit 1f279e6 into master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants