Default to -Wall (but not -Werror)

[schmonz]

1. Get to warning-free builds in our usual dev environments

2. Submit a PR adding -Wall -Werror to conf-cc (and maybe shrinking our CI build matrix)

3. Test it on every platform we can get our hands on

4. Fix whatever comes up

5. Merge

6. Rejoice!

7. Proceed directly to Make regular use of code analysis tools #48

[schmonz]

#83

[schmonz]

Must have click tapped something by mistake, this ain’t done yet

[DerDakon]

Just to make this clear: this affects only CI builds, no? Otherwise I'll hate you for -Werror as it will break with every new compiler version and any released version.

[schmonz]

Hmmm, I had been thinking we’d use it daily and fix whatever comes up, and ship with it and fix whatever users report. So yeah, the default conf-cc. Which scenario (or both) are you worried about?

[DerDakon]

The point is to have it in the CI so we see everything that happens for us, but not have it in the default that ships to a user as that could easily break if it is built with a different compiler or on a different platform for no good reason. -Wall is fine, but not -Werror.