Repository navigation
move some variables to a more local scope - #111
Merged
Merged
Conversation
schmonz
approved these changes
Dec 27, 2019
schmonz
left a comment
schmonz
left a comment
Member
There was a problem hiding this comment.
Looks reasonable. What brought these to your attention — happened to be reading this file, or experimenting with compiler warnings, or something else? (My motivation for asking: I’m reminding myself and the rest of us that the sooner we start ratcheting up compiler warnings and other static analysis, the better. So the sooner we can build warning-free with gcc and clang defaults, the sooner we can turn up the warnings, the sooner we can have a little more safety for every commit.)
Member
Author
|
I was just looking again on #83. |
mbhangui
approved these changes
Dec 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No target release given, I would just merge it once positive reviews are there.