rename local variables shadowing global variables of the same name#113
Merged
Conversation
schmonz
approved these changes
Dec 31, 2019
schmonz
left a comment
schmonz
left a comment
Member
There was a problem hiding this comment.
Good idea. This may make fuzz for some third-party patches but we decided, IIRC, we’re okay with that. I am, anyway, if it gets us code that’s harder to interpret incorrectly. As usual, I’m curious how this popped up on your radar — compiler warnings?
Member
Author
|
Yes, running with -Wshadow. |
DerDakon
force-pushed
the
Dakon-vshadow
branch
2 times, most recently
from
c6d525a to
1b163f9
Compare
DerDakon
force-pushed
the
Dakon-vshadow
branch
from
1b163f9 to
eef1f27
Compare
Member
Author
|
The part in cdbmake_add.c collides with #124. It can just be dropped when that is merged first. |
mbhangui
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Again I would merge this whenever it is ready, preferable even for 1.08.