Skip to content

use default strdup() instead of open coding it - #130

Merged
DerDakon merged 1 commit into
masterfrom
Dakon-strdup
May 22, 2020
Merged

DerDakon merged 1 commit into
masterfrom
Dakon-strdup

Conversation

@DerDakon

Copy link
Copy Markdown
Member

No description provided.

@leahneukirchen

Copy link
Copy Markdown
Contributor

LGTM.

sendmail.c:do_sender uses an open coded strndup, I'm not sure which version of POSIX we are targeting?

@DerDakon

Copy link
Copy Markdown
Member Author

For the moment I would keep it as low as possible.

@DerDakon DerDakon added this to the 1.09 milestone May 18, 2020
@DerDakon
DerDakon requested a review from josuah May 18, 2020 18:58

@josuah josuah left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose alloc() was required as a custom allocator was used. After we remove it (#124), this change looks natural.

@DerDakon
DerDakon merged commit 43b7cb5 into master May 22, 2020
@DerDakon
DerDakon deleted the Dakon-strdup branch May 22, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants