fix catman rules and tests - #134
Merged
Merged
Conversation
These things just set environment variables, but since they were note exported they were not visible to make, so nothing actually changed.
DerDakon
requested review from
alanpost,
jlmuir,
josuah,
leahneukirchen,
mbhangui,
schmonz and
xenotrope
May 19, 2020 20:36
schmonz
requested changes
May 19, 2020
DerDakon
force-pushed
the
Dakon-NROFF-CI
branch
2 times, most recently
from
May 19, 2020 20:57
f47136b to
8498bd7
Compare
schmonz
approved these changes
May 19, 2020
The previous version only worked with GNU make. It was not caught because of broken CI rules.
leahneukirchen
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the changes from #116 actually work as intended.