Skip to content

Symlink "CI" configs somewhere easier to see. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schmonz merged 1 commit into from
Nov 30, 2020
Merged

Symlink "CI" configs somewhere easier to see. #148

schmonz merged 1 commit into from
Nov 30, 2020

Conversation

@schmonz
Copy link
Member

@schmonz schmonz commented Jun 11, 2020

I don't think about our autobuilders as often as I should. When I do, I'm never sure I'm looking at all of them. This might help me.

@schmonz schmonz added the build label Jun 11, 2020
@schmonz schmonz added this to the 1.09 milestone Jun 11, 2020
@josuah josuah mentioned this pull request Jun 14, 2020
Open
josuah
josuah approved these changes Jun 14, 2020
View reviewed changes
Copy link

@josuah josuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ideal would have been everyone make-up their mind and always use a prefix, like "/ci" instead of everyone picking its favorite dotfile subdirectory, but given the state of the affairs, I guess this is the best we will have.

Sometimes we see source in /src and everything else in the root under various directories, along with tests, this starts the convention of having top-level directories for non-code resources, and plain files for the source code, immediately exposed.

@schmonz schmonz removed the request for review from alanpost November 3, 2020 15:02
@schmonz schmonz force-pushed the schmonz-builds-symlinks branch from 6e30065 to 2d6324e Compare November 20, 2020 20:11
DerDakon
DerDakon requested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@DerDakon DerDakon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add it to .gitattributes as there is no value in having that in the release tarball when we also filter out the actual configs.

Also I'm thinking about naming it maybe "autobuilds" to make it a bit more obvious. Opinions?

@schmonz schmonz force-pushed the schmonz-builds-symlinks branch from 2d6324e to 45f5b34 Compare November 30, 2020 11:54
@schmonz
Copy link
Member Author

schmonz commented Nov 30, 2020

Please also add it to .gitattributes as there is no value in having that in the release tarball when we also filter out the actual configs.

Also I'm thinking about naming it maybe "autobuilds" to make it a bit more obvious. Opinions?

Agree. I've done both.

@DerDakon DerDakon self-requested a review November 30, 2020 16:55
@schmonz schmonz merged commit 5b825d2 into master Nov 30, 2020
@schmonz schmonz deleted the schmonz-builds-symlinks branch November 30, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbhangui mbhangui mbhangui approved these changes

@DerDakon DerDakon DerDakon approved these changes

@josuah josuah josuah approved these changes

@jlmuir jlmuir Awaiting requested review from jlmuir

@leahneukirchen leahneukirchen Awaiting requested review from leahneukirchen

@xenotrope xenotrope Awaiting requested review from xenotrope

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

1.09

Development

Successfully merging this pull request may close these issues.

5 participants

@schmonz @mbhangui @DerDakon @josuah