qmail-smtpd: allow [] to appear in received lines #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDakon
requested review from
alanpost,
jlmuir,
josuah,
leahneukirchen,
mbhangui,
schmonz and
xenotrope
Contributor
|
I have a bunch of emails with |
Contributor
|
sqmail also allows spaces, btw. |
leahneukirchen
approved these changes
Jul 7, 2020
mbhangui
approved these changes
Jul 8, 2020
josuah
approved these changes
Jul 8, 2020
A client that can't find out the hostname should send "[ip.ad.dr.ess]" as HELO or EHLO string. But since the square brackets were considered unsafe qmail-smtpd mangled them to ? in the Received line actually written to the mail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client that can't find out the hostname should send "[ip.ad.dr.ess]" as HELO or EHLO string. But since the square brackets were considered unsafe qmail-smtpd mangled them to ? in the Received line actually written to the mail.