get rid of error_* variables and just #define them to their errno equivalents #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDakon
requested review from
alanpost,
jlmuir,
josuah,
leahneukirchen,
mbhangui,
schmonz and
xenotrope
Contributor
|
Adjust error_str.c and error_temp.c too? |
Member
Author
|
None of the extra cases in these files match with the values changed here. I have not touched any existing code that uses these variables/defines. |
Member
Author
|
Fun fact: cdb_seek.c uses |
schmonz
approved these changes
Aug 3, 2020
DerDakon
force-pushed
the
Dakon-errno
branch
from
61ebb79 to
7b8f799
Compare
josuah
approved these changes
Nov 8, 2020
josuah
left a comment
josuah
left a comment
There was a problem hiding this comment.
They are all in POSIX https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html and I should be present on everything notqmail targets.
mbhangui
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more part of #65.