Add some tests for prioq. #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbhangui
approved these changes
Nov 3, 2020
DerDakon
requested changes
Nov 3, 2020
Member
DerDakon
left a comment
DerDakon
left a comment
There was a problem hiding this comment.
Be a bit more paranoid about reused values ;) LGTM otherwise.
DerDakon
approved these changes
Nov 4, 2020
josuah
approved these changes
Nov 8, 2020
josuah
left a comment
josuah
left a comment
There was a problem hiding this comment.
Tests are a good way to document libraries through providing examples.
Do we aim covering more of the code base this way?
Thank you and ok josuah
Member
Author
I personally enjoy it, which is why I wrote these particular tests. Conveniently, getting code under automated test is a huge lever for preserving and improving our code -- and therefore ultimately for making notqmail development faster and more fun. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.