do not use Posix style -n argument for tail #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentially was changed from "tail -1" to "tail -n -1" instead of "tail -n 1". Even worse, the tail on Solaris doesn't seem to work with either options.
DerDakon
requested review from
josuah,
leahneukirchen,
mbhangui and
schmonz
as code owners
josuah
approved these changes
Jan 17, 2021
josuah
left a comment
josuah
left a comment
There was a problem hiding this comment.
Solaris may accept tail -n 1 or maybe tail -n1 as per documentation :
https://docs.oracle.com/cd/E26502_01/html/E29030/tail-1.html
Member
Author
Yes, but only for one of the 2 tail implementations. There seems to be only one head, with supports |
schmonz
approved these changes
Jan 21, 2021
Member
schmonz
left a comment
schmonz
left a comment
There was a problem hiding this comment.
I agree we need to fix the Solaris build, so I’m glad you set up an autobuild for it and found this.
The net change itself feels weird, calling head one way and tail another, but if that’s an accurate reflection of the situation then it probably doesn’t matter that it feels weird.
leahneukirchen
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentially was changed from "tail -1" to "tail -n -1" instead of "tail -n 1". Even worse, the tail on Solaris doesn't seem to work with either options.