add noreturn attribute to a couple of functions #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDakon
requested review from
josuah,
leahneukirchen,
mbhangui and
schmonz
as code owners
mbhangui
approved these changes
Jan 28, 2021
schmonz
reviewed
Jan 28, 2021
DerDakon
force-pushed
the
Dakon-noreturn
branch
from
6907f88 to
484ad73
Compare
When building with -Wextra there are a lot of false positives for fallthroughs, which happen because the compiler does not detect that these functions in fact never return. Add an attribute if building with gcc. According to the documentation it is supported since version 2.5, which is way older than anything one can reasonably expect this to work on.
DerDakon
force-pushed
the
Dakon-noreturn
branch
from
484ad73 to
4a48232
Compare
schmonz
approved these changes
Jan 29, 2021
josuah
approved these changes
Jan 30, 2021
josuah
left a comment
josuah
left a comment
There was a problem hiding this comment.
I am always sad to add compiler-specific flags and attributes. But notqmail is developped for angry noisy compilers, so it is a necessary evil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with -Wextra there are a lot of false positives for fallthroughs, which happen because the compiler does not detect that these functions in fact never return. Add an attribute if building with gcc. According to the documentation it is supported since version 2.5, which is way older than anything one can reasonably expect this to work on.