Skip to content

Add a patch breakage checker to continuous build - #225

Open
josuah wants to merge 1 commit into
mainfrom
josuah-patch-checker
Open

Add a patch breakage checker to continuous build#225
josuah wants to merge 1 commit into
mainfrom
josuah-patch-checker

Conversation

@josuah

@josuah josuah commented Oct 4, 2021

Copy link
Copy Markdown

I propose to move my https://github.com/josuah/notqmail-patch to https://github.com/notqmail/notqmail-patch (or any better name), so that anyone allowed to alter notqmail can also alter notqmail-patch.

Then, what about this to check for patch compatiblity ?

This also lets us maintain adapted versions of the patches, and adapt them as we break them.

In the end, some way for us to keep patches going as we move things around.

@josuah

josuah commented Oct 4, 2021

Copy link
Copy Markdown
Author

On the build below, you see the "Patch Compatibility" at work on the 6th line.

I will try rebasing some patches in the meantime.

@DerDakon

DerDakon commented Oct 4, 2021

Copy link
Copy Markdown
Member

Since cirrus-ci is often crowded and somewhat slow, can we get the same as a Github action? That would avoid any outside dependencies.

@josuah

josuah commented Oct 4, 2021

Copy link
Copy Markdown
Author

My, my! It IS a Github action. .github/workflows/patch.yml (title edited).

I first tried as a Cirrus build, not sure why, I'm new to CI.

@josuah josuah changed the title [WIP] Add a patch breakage checker to cirrus build [WIP] Add a patch breakage checker to continuous build Oct 4, 2021
@DerDakon

Copy link
Copy Markdown
Member

I think for a start: yes, please, move the repo into notqmail. But I dislike the "notqmail-patch" name, this can be understood as if it does something entirely different. How about "brokemaster" then?

@josuah

josuah commented May 9, 2022

Copy link
Copy Markdown
Author

Back to it after a long while.
I am adding some cleanup and adding a https://github.com/notqmail/brokemaster/ repo...

@josuah
josuah force-pushed the josuah-patch-checker branch 3 times, most recently from b7391ec to 3d756e3 Compare May 9, 2022 16:18
@josuah josuah changed the title [WIP] Add a patch breakage checker to continuous build Add a patch breakage checker to continuous build May 9, 2022
@josuah

josuah commented May 9, 2022

Copy link
Copy Markdown
Author

That looks like running to completion. We are good now, ready for review.

Let's see how it turns out in practice?
For now, the build is required, I can try to make it optional if you prefer.

@josuah
josuah requested review from jlmuir and xenotrope May 9, 2022 16:41
@josuah josuah self-assigned this May 9, 2022
@josuah josuah added the build label May 9, 2022

@DerDakon DerDakon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest also renaming the name of the workflow to "brokemaster" or something like that as well. Also please add a symlink to autobuilds/.

@josuah

josuah commented Oct 16, 2022

Copy link
Copy Markdown
Author

After too long, the suggested changes are completed.
Thank you for your patience.

@DerDakon
DerDakon self-requested a review October 16, 2022 09:17
@schmonz schmonz mentioned this pull request Jan 17, 2024
@schmonz schmonz linked an issue Feb 1, 2024 that may be closed by this pull request
@schmonz schmonz added this to the 1.09.1 milestone Feb 1, 2024
@schmonz
schmonz force-pushed the josuah-patch-checker branch from 09afd64 to f39d7f3 Compare December 22, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test that popular patches still apply cleanly

3 participants