Skip to content

autobuilds: add Fedora Rawhide, drop OpenBSD 7.2 - #269

Merged
schmonz merged 3 commits into
masterfrom
schmonz-autobuilds-rawhide
Mar 6, 2024
Merged

schmonz merged 3 commits into
masterfrom
schmonz-autobuilds-rawhide

Conversation

@schmonz

@schmonz schmonz commented Mar 3, 2024

Copy link
Copy Markdown
Member

Open Build Service gives a build error with Fedora Rawhide, gcc 14, and these build flags:

[   20s] + CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer '
[   20s] + export CFLAGS
[   20s] + CXXFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer '
[   20s] + export CXXFLAGS
[   20s] + FFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I/usr/lib64/gfortran/modules '
[   20s] + export FFLAGS
[   20s] + FCFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I/usr/lib64/gfortran/modules '
[   20s] + export FCFLAGS
[   20s] + VALAFLAGS=-g
[   20s] + export VALAFLAGS
[   20s] + RUSTFLAGS='-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Cforce-frame-pointers=yes -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes'
[   20s] + export RUSTFLAGS
[   20s] + LDFLAGS='-Wl,-z,relro -Wl,--as-needed  -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld-errors -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes '
[   20s] + export LDFLAGS

The error:

+ make -s it man NROFF=true
[   21s] seek_cur.c: In function ‘seek_cur’:
[   21s] seek_cur.c:7:10: error: implicit declaration of function ‘lseek’ [-Wimplicit-function-declaration]
[   21s]     7 | { return lseek(fd,(off_t) 0,CUR); }
[   21s]       |          ^~~~~
[   21s] make: *** [Makefile:1711: seek_cur.o] Error 1

This PR adds Fedora Rawhide (with nearly all of the same flags) to our build matrix, but does not reproduce the error seen on OBS.

(Also, OpenBSD 7.2 is no longer available from its CDN, so I'm removing it from our build matrix. I've already removed it from our branch protection rules.)

@schmonz schmonz added this to the 1.09 milestone Mar 3, 2024
@mbhangui

mbhangui commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Open Build Service gives a build error with Fedora Rawhide, gcc 14, and these build flags:
...

The error:

+ make -s it man NROFF=true
[   21s] seek_cur.c: In function ‘seek_cur’:
[   21s] seek_cur.c:7:10: error: implicit declaration of function ‘lseek’ [-Wimplicit-function-declaration]
[   21s]     7 | { return lseek(fd,(off_t) 0,CUR); }
[   21s]       |          ^~~~~
[   21s] make: *** [Makefile:1711: seek_cur.o] Error 1

This PR adds Fedora Rawhide (with nearly all of the same flags) to our build matrix, but does not reproduce the error seen on OBS.

It is possible that the action script is using a slightly older gcc compared to obs. Few days back the compilation went through without error. obs is currently using gcc-14.0.1-0.8 from fedora core 41 on rawhide.

@mbhangui

mbhangui commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

The reason we are getting error on obs is because it is compiling notqmail-1.08 which has seek_cur.c. The current notqmail doesn't have seek_cur.c and seek_cur() function is defined in seek.h as below and seek.h includes unistd.h

#define seek_cur(fd) (lseek((fd), 0, SEEK_CUR))

@schmonz

schmonz commented Mar 6, 2024

Copy link
Copy Markdown
Member Author

Aha! That explains it. We had thought this build error from OBS was an oversight on our part, but seems not. Phew. We'll keep on broadening our platform builders, ratcheting our compiler warnings tighter, and staying alert to the possibility that we've missed something important.

@schmonz
schmonz merged commit 6ab9eaa into master Mar 6, 2024
@schmonz
schmonz deleted the schmonz-autobuilds-rawhide branch March 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants