Skip to content

use <stdint.h> to get a really portable 32 bit unsigned type - #30

Merged
schmonz merged 1 commit into
masterfrom
stdint
Sep 4, 2019
Merged

use <stdint.h> to get a really portable 32 bit unsigned type#30
schmonz merged 1 commit into
masterfrom
stdint

Conversation

@DerDakon

Copy link
Copy Markdown
Member

This in turn requires a compiler from the 21st century.

@DerDakon DerDakon added the build label Jul 16, 2019
@schmonz

schmonz commented Jul 19, 2019

Copy link
Copy Markdown
Member

As usual, I like the change, and am concerned only about timing.

Without this fix, what's at risk? Are there systems that won't compile, systems that'll exhibit surprising runtime behavior, and/or something else entirely?

With this fix, what's at risk? Normally here I'd be concerned about users being able to keep applying their patches, but this one is pretty self-contained. What else should we consider about when is best to merge this?

@DerDakon

Copy link
Copy Markdown
Member Author

This will not work on systems that do not support C99, as they likely do not have that header. For all other systems using unsigned long at all was IMHO a bad idea, unsigned int is really 32 bit everywhere for ages.

@alanpost alanpost added this to the 1.08 milestone Jul 19, 2019
@DerDakon
DerDakon force-pushed the stdint branch 2 times, most recently from e1ffc95 to 2923d05 Compare August 19, 2019 21:56
This in turn requires a compiler from the 21st century.
@schmonz
schmonz merged commit cc9df61 into master Sep 4, 2019
@schmonz
schmonz deleted the stdint branch September 4, 2019 19:14
@DerDakon DerDakon modified the milestones: 1.09, 1.08 Dec 28, 2019
@DerDakon
DerDakon removed the request for review from alanpost December 28, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants