Conversation
mbhangui
approved these changes
Jul 19, 2019
Member
|
As usual, I like the change, and am concerned only about timing. Without this fix, what's at risk? Are there systems that won't compile, systems that'll exhibit surprising runtime behavior, and/or something else entirely? With this fix, what's at risk? Normally here I'd be concerned about users being able to keep applying their patches, but this one is pretty self-contained. What else should we consider about when is best to merge this? |
Member
Author
|
This will not work on systems that do not support C99, as they likely do not have that header. For all other systems using |
DerDakon
force-pushed
the
stdint
branch
2 times, most recently
from
August 19, 2019 21:56
e1ffc95 to
2923d05
Compare
This in turn requires a compiler from the 21st century.
schmonz
approved these changes
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This in turn requires a compiler from the 21st century.