Skip to content

split conf-qmail in to conf-qmail-bin, conf-qmail-queue, conf-qmail-man, etc. - #35

Closed
alanpost wants to merge 27 commits into
notqmail:masterfrom
alanpost:pr-XX-conf-qmail-fhs
Closed

alanpost wants to merge 27 commits into
notqmail:masterfrom
alanpost:pr-XX-conf-qmail-fhs

Conversation

@alanpost

Copy link
Copy Markdown
Contributor

This is a technology preview. This PR is not ready to merge.

@alanpost alanpost added this to the 1.08 milestone Jul 19, 2019
@alanpost
alanpost force-pushed the pr-XX-conf-qmail-fhs branch from 6489b46 to bde3b7f Compare July 19, 2019 16:54
@alanpost
alanpost force-pushed the pr-XX-conf-qmail-fhs branch from bde3b7f to 02c3499 Compare July 20, 2019 00:34
@alanpost
alanpost force-pushed the pr-XX-conf-qmail-fhs branch 5 times, most recently from d239825 to ae8cdcc Compare August 10, 2019 21:33
@alanpost
alanpost force-pushed the pr-XX-conf-qmail-fhs branch 2 times, most recently from 31fc962 to fd4964a Compare August 25, 2019 14:29
@josuah

josuah commented Apr 11, 2020

Copy link
Copy Markdown

I see this as a fix to #2. Reading the sources again, it looks like the running part of qmail (qmail-*) are compatible with such changes:

$ grep -e '["/]queue["/]' *.[ch] | grep -v '^hier.c:'
qmail-clean.c: if (chdir("queue") == -1) _exit(111);
qmail-qread.c: if (chdir("queue") == -1) die_chdir();
qmail-queue.c: if (chdir("queue") == -1) die(62);
qmail-send.c: while (chdir("queue") == -1)
qmail-send.c: if (chdir("queue") == -1)
qmail-tcpok.c:  if (chdir("queue/lock") == -1)
qmail-tcpok.c:    strerr_die4sys(111,FATAL,"unable to chdir to ",auto_qmail,"/queue/lock: ");
qmail-tcpok.c:    strerr_die4sys(111,FATAL,"unable to write ",auto_qmail,"/queue/lock/tcpto: ");
qmail-tcpok.c:    strerr_die4sys(111,FATAL,"unable to lock ",auto_qmail,"/queue/lock/tcpto: ");
qmail-tcpok.c:    strerr_die4sys(111,FATAL,"unable to clear ",auto_qmail,"/queue/lock/tcpto: ");
qmail-tcpto.c: if (chdir("queue/lock") == -1) die_chdir();
spawn.c: if (chdir("queue/mess") == -1) _exit(111);
tcpto.c: fdlock = open_write("queue/lock/tcpto");
tcpto.c: fd = open_read("queue/lock/tcpto");

Only chdir() to the queue, or open_{read,write} in tcpto.c accesses the queue directory directly, probably omission by the author who use chdir everywhere else, and handled properly in the changes proposed.

@josuah

josuah commented May 19, 2020

Copy link
Copy Markdown

I am running on this branch of notqmail for my personnal mail server since a few months and I do not have issue anywhere.

On the other hand, I have a simplistic configuration and do not explore every feature on my setup.

But this suggest that (not)qmail get back on its feet with such changes.

Comment thread conf-qmail
@josuah

josuah commented Oct 3, 2021

Copy link
Copy Markdown

I like the idea, but this diverged too much and applying manually on top of Master would be easier.

@josuah josuah closed this Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants