cleanup: remove exit.h, use unistd.h instead. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpost
force-pushed
the
pr-remove-exit-h
branch
from
262a77d to
9845b32
Compare
alanpost
changed the title
|
The target branch of this PR is not master, which looks odd. |
alanpost
force-pushed
the
pr-remove-exit-h
branch
2 times, most recently
from
c42db5a to
50c9b59
Compare
alanpost
force-pushed
the
pr-remove-readwrite-h
branch
2 times, most recently
from
b9e235a to
c3374c3
Compare
alanpost
force-pushed
the
pr-remove-exit-h
branch
from
50c9b59 to
ac1b728
Compare
alanpost
force-pushed
the
pr-remove-readwrite-h
branch
2 times, most recently
from
c7d7ebf to
a1e7caa
Compare
alanpost
force-pushed
the
pr-remove-exit-h
branch
from
ac1b728 to
3e97d15
Compare
As this series of commits is split in to those suitable for 1.08, and those targeted for 1.9, I've set the target branch to master. I have cherry-picked the 1.08 readwrite.h commit from PR # 80 instead of the 1.9 readwrite.h PR #43 , as this exit.h PR absolutely requires something be done about the declarations in readwrite.h but doesn't require removing that header in favor of unistd.h. As a result each PR (#43 and #44) now have fewer dependencies on the other. I've updated the milestone for this PR to the 1.9 release. I've submitted PR #79 for the beginning of this series, with the minimal change for the 1.08 release. |
alanpost
force-pushed
the
pr-remove-exit-h
branch
3 times, most recently
from
f5da7d1 to
d884a63
Compare
_exit(2) is declared in unistd.h. Instead of redeclaring it in exit.h, include that system header to get the correct function signature.
Both of these programs call _exit but don't include the exit.h header where it is declared. Inspired by Gentoo's 1.06-exit.patch.
Neither of these programs calls _exit. forward calls strerr_die2x with a status of 0, in order to send a log message. maildirwatch runs in a loop and never exits.
_exit(2) is declared in unistd.h.
alanpost
force-pushed
the
pr-remove-exit-h
branch
from
d884a63 to
ab19893
Compare
josuah
approved these changes
May 19, 2020
DerDakon
requested review from
DerDakon,
schmonz,
jlmuir,
leahneukirchen,
mbhangui and
xenotrope
leahneukirchen
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes exit.h to replace it with unistd.h. The same approach was used in PR #43, which removes readwrite.h, so this PR builds on that one. They touch a lot of the same files.
exit.h only includes system-defined functions, and since _exit is so basic to a process it shows up all over the codebase. It's a reasonable start for removing redeclaration of system functions (issue #7), as it touches a lot of files and includes a system header that has the bulk of the declarations we no longer want to shadow.
Alas, exit.h removal cannot be done before PR #43, as including unistd.h causes compiler errors when including the readwrite.h header. As a result I'm experimenting here with separate PRs for otherwise incidentally staged commits.