Skip to content

add missing forward declarations for project functions #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2019
Merged

add missing forward declarations for project functions #64

merged 3 commits into from
Aug 26, 2019

Conversation

DerDakon
Copy link
Member

No description provided.

@DerDakon DerDakon requested review from schmonz and alanpost August 20, 2019 20:09
@DerDakon DerDakon added the build label Aug 20, 2019
@alanpost alanpost added this to the 1.08 milestone Aug 22, 2019
alanpost
alanpost approved these changes Aug 25, 2019
View reviewed changes
Copy link
Contributor

@alanpost alanpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I had to cherry-pick these commits in to testing branches while I worked on -Wall -Werror. I'm particularly fond of the hier.h commit, but the more straightforward missing header declarations correctness fixes are simply good finds.

@schmonz
Copy link
Member

schmonz commented Aug 26, 2019

Yes, excellent catches.

@alanpost alanpost merged commit 7db974d into master Aug 26, 2019
@alanpost alanpost deleted the missing-decl branch August 26, 2019 04:04
@DerDakon DerDakon modified the milestones: 1.09, 1.08 Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmonz schmonz schmonz approved these changes

@alanpost alanpost alanpost approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
1.08
Development

Successfully merging this pull request may close these issues.
3 participants
@DerDakon @schmonz @alanpost