Open
Conversation
alanpost
force-pushed
the
pr-remove-install
branch
from
2acba4c to
60d60d0
Compare
|
If the install script is gone, an install makefile target could see the day? #9 |
josuah
reviewed
Apr 11, 2020
| ./compile hostname.c | ||
|
|
||
| install: | ||
| echo './instpackage && ./instchown' > install |
There was a problem hiding this comment.
What about keeping:
install:
./instpackage
I do not think that anyone who discovered qmail got used to run make install for regenerate this simple shell script, and rather have the install target called as a dependency of make it.
So we might not break any expectation through your deletion. Do I open a separate branch for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the opportunity of the 2.0 release to remove a backward compatibility thunk, the install script, in favor of directly calling instpackage and instcheck, as our packaging tools already do.