-
Notifications
You must be signed in to change notification settings - Fork 30
add missing return types to main() #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A similar treatment (adding explicit void to main) should be given to the following files: trylsock.c |
good catch, no idea why I did not spot them. |
d4511a8
to
92f7884
Compare
92f7884
to
9ff954f
Compare
9ff954f
to
65ab0e3
Compare
The point is: main() is void everywhere, because it does not return and the return code comes from _exit(). I avoid _exit() here to not drag in more headers for no reasons, and just make it |
Nowhere in the codebase does it return from main. Everywhere it calls _exit. We should preserve that behavior. |
65ab0e3
to
62afa31
Compare
Btw, Clang now issues these warnings:
|
62afa31
to
0d36c26
Compare
I'm back to "int main()" now. Fixing one warning with another does not help, and the consistency doesn't give us anything, especially as it's only about try*.c where noone needs to look on any bigger API or structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a CHANGES
entry. (Good time to refresh ourselves on our criteria for pull requests.)
0d36c26
to
cd8193f
Compare
No description provided.