-
Notifications
You must be signed in to change notification settings - Fork 30
remove inefficient maildirwatch #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
640340a
to
6834c3f
Compare
If I ever used maildirwatch, I don't remember it. But now I'm thinking that when we have user-facing functionality we intend to remove, and we can't be absolutely sure nobody uses it, we should publish our intent in advance. For example, in 1.08's release notes we can say "We plan to remove maildirwatch in our next release. We believe it's no longer relevant now that Maildir has wide tool support. If you still use maildirwatch, now's a good time to let us know." |
Second (maybe third) thoughts: meh. Maybe that'll be important when we have more users. For now, if we want to delete, let's delete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qmail.7 has a reference to maildirwatch that needs to be removed.
Fourth thoughts, after IRC discussion with @alanpost: Given our claim to be conservative and careful, if we remove a program that someone was relying on without giving them a chance to change our minds, they will consider our claim false. It's expensive to have users perceiving us as rash; it's cheap to wait a little longer before deleting (or treating as extensions, which might feel pretty similarly satisfying). I've added Intent to remove to the 1.08 release notes, and a reminder in the 1.9 roadmap. |
6834c3f
to
39b6a60
Compare
fine with me. |
39b6a60
to
263f409
Compare
263f409
to
3092980
Compare
3092980
to
bf1f94a
Compare
4c14801
to
7c257f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also prune the cross-ref to maildirwatch in qmail.7.
7c257f4
to
02a2906
Compare
a0f2a89
to
bc1a4ba
Compare
This made sense at a time where maildir was a new concept, but most relevant mailers natively support maildir these days. There are also more efficient syscalls to watch directories meanwhile, and people usually also do not have local mail stores anyway. If one really needs it this can be done more efficiently using e.g. the *notify() syscalls on Linux.
bc1a4ba
to
8a5ef2b
Compare
This made sense at a time where maildir was a new concept, but most relevant mailers natively support maildir these days. There are also more efficient syscalls to watch directories meanwhile, and people usually also do not have local mail stores anyway.