Skip to content

remove inefficient maildirwatch #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

DerDakon
Copy link
Member

This made sense at a time where maildir was a new concept, but most relevant mailers natively support maildir these days. There are also more efficient syscalls to watch directories meanwhile, and people usually also do not have local mail stores anyway.

@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch from 640340a to 6834c3f Compare August 27, 2019 18:48
@schmonz
Copy link
Member

schmonz commented Aug 28, 2019

If I ever used maildirwatch, I don't remember it. But now I'm thinking that when we have user-facing functionality we intend to remove, and we can't be absolutely sure nobody uses it, we should publish our intent in advance. For example, in 1.08's release notes we can say "We plan to remove maildirwatch in our next release. We believe it's no longer relevant now that Maildir has wide tool support. If you still use maildirwatch, now's a good time to let us know."

@schmonz
Copy link
Member

schmonz commented Sep 2, 2019

we should publish our intent in advance

Second (maybe third) thoughts: meh. Maybe that'll be important when we have more users. For now, if we want to delete, let's delete.

Copy link
Member

@schmonz schmonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qmail.7 has a reference to maildirwatch that needs to be removed.

@schmonz schmonz added this to the 1.9 milestone Sep 2, 2019
@schmonz
Copy link
Member

schmonz commented Sep 2, 2019

we should publish our intent in advance

Second (maybe third) thoughts: meh. Maybe that'll be important when we have more users. For now, if we want to delete, let's delete.

Fourth thoughts, after IRC discussion with @alanpost: Given our claim to be conservative and careful, if we remove a program that someone was relying on without giving them a chance to change our minds, they will consider our claim false. It's expensive to have users perceiving us as rash; it's cheap to wait a little longer before deleting (or treating as extensions, which might feel pretty similarly satisfying).

I've added Intent to remove to the 1.08 release notes, and a reminder in the 1.9 roadmap.

@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch from 6834c3f to 39b6a60 Compare September 2, 2019 18:36
@DerDakon
Copy link
Member Author

DerDakon commented Sep 2, 2019

fine with me.

@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch from 39b6a60 to 263f409 Compare October 3, 2019 18:56
@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch from 263f409 to 3092980 Compare December 27, 2019 23:34
@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch from 3092980 to bf1f94a Compare January 5, 2020 18:01
@DerDakon DerDakon modified the milestones: 1.90, 1.09 Mar 19, 2020
@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch from 4c14801 to 7c257f4 Compare May 23, 2020 11:25
@DerDakon DerDakon requested review from josuah and leahneukirchen May 23, 2020 11:26
Copy link
Member

@schmonz schmonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also prune the cross-ref to maildirwatch in qmail.7.

@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch from 7c257f4 to 02a2906 Compare May 23, 2020 14:22
@DerDakon DerDakon requested a review from schmonz June 11, 2020 15:36
@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch 2 times, most recently from a0f2a89 to bc1a4ba Compare June 14, 2020 16:25
This made sense at a time where maildir was a new concept, but most relevant
mailers natively support maildir these days. There are also more efficient
syscalls to watch directories meanwhile, and people usually also do not have
local mail stores anyway. If one really needs it this can be done more
efficiently using e.g. the *notify() syscalls on Linux.
@DerDakon DerDakon force-pushed the Dakon-remove-maildirwatch branch from bc1a4ba to 8a5ef2b Compare June 18, 2020 15:16
@DerDakon DerDakon merged commit 8a5ef2b into master Jun 19, 2020
@DerDakon DerDakon deleted the Dakon-remove-maildirwatch branch June 19, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants