Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSD1331 #50

Merged
merged 1 commit into from Nov 10, 2013

Conversation

@asmecher
Copy link
Contributor

commented Nov 9, 2013

Hi! I adapted the SSD1351 driver for the SSD1331. The existing SSD1351 driver can't be used e.g. with a new init sequence (see issue #27) because the write_register function for SSD1331 requires the D/C line to be kept in command mode throughout the (potentially) multi-byte register write sequence. There's also not an "enter write mode" command for SSD1331, so D/C needs to be toggled back and forth. This could probably be cleaned up, but works for me.

@asmecher asmecher referenced this pull request Nov 9, 2013
@notro

This comment has been minimized.

Copy link
Owner

commented Nov 10, 2013

Why is write_reg8_bus8() needed?
As far as I can tell, it's the same as the default, except for removing startbyte support and pulling up 'dc' at the end.
It should not be necessary to pull up 'dc', as write_mem() is the only one that needs this, and it is taken care of.

@asmecher

This comment has been minimized.

Copy link
Contributor Author

commented Nov 10, 2013

The default implementation has DC low for the first byte of a register write; see https://github.com/notro/fbtft/blob/master/fbtft-bus.c#L42 for DC level change. The SSD1331 needs DC low for the whole thing so I removed that line in the SSD1331 implementation.

notro added a commit that referenced this pull request Nov 10, 2013

@notro notro merged commit 663a4b2 into notro:master Nov 10, 2013

@notro

This comment has been minimized.

Copy link
Owner

commented Nov 10, 2013

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.