Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make journal type params more expressive #43

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@Leammas
Copy link
Contributor

commented Apr 19, 2018

As I was ought to write type by hand, it was a bit hard to reason about params

@notxcain

This comment has been minimized.

Copy link
Owner

commented May 7, 2018

I'm not sure that it's a good change. Long abstract type names clutter the code. And actually short names are only hard the first time you read the declaration.
What I'm certain about is that it definitely needs:

  1. Scaladoc
  2. Renaming I (was short for Identifier) to K (short for key) for consistency.

@Leammas Leammas force-pushed the Leammas:param_naming branch from c3d1452 to 12a2f8f May 29, 2018

@Leammas

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2018

Can't agree about cluttering the code since you only see them when you read it (and library code is read more often than written). Nevertheless changed for K.

@notxcain

This comment has been minimized.

Copy link
Owner

commented Apr 8, 2019

Thanks!

@notxcain notxcain merged commit fe5e903 into notxcain:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Leammas Leammas deleted the Leammas:param_naming branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.