From 249706905e5e8539a6ff5fb81106a0694a3aba51 Mon Sep 17 00:00:00 2001 From: liangbowen Date: Tue, 1 Aug 2023 08:59:16 +0800 Subject: [PATCH] use try-with-resources in KyuubiCommands --- .../java/org/apache/hive/beeline/KyuubiCommands.java | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java b/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java index af294ac6f6f..4675cee1406 100644 --- a/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java +++ b/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java @@ -86,10 +86,9 @@ private boolean sourceFile(String cmd) { } private boolean sourceFileInternal(File sourceFile) throws IOException { - BufferedReader reader = null; - try { - reader = new BufferedReader(new FileReader(sourceFile)); - String lines = null, extra; + try (BufferedReader reader = new BufferedReader(new FileReader(sourceFile))) { + String lines = null; + String extra; while ((extra = reader.readLine()) != null) { if (beeLine.isComment(extra)) { continue; @@ -107,10 +106,6 @@ private boolean sourceFileInternal(File sourceFile) throws IOException { return false; } } - } finally { - if (reader != null) { - reader.close(); - } } return true; }