Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ethereum keys #1268

Merged
merged 39 commits into from
Oct 6, 2022
Merged

feat: ethereum keys #1268

merged 39 commits into from
Oct 6, 2022

Conversation

montekki
Copy link
Contributor

@montekki montekki commented Sep 8, 2022 •
edited
Loading

Purpose

Support Ethereum accounts on Moonbeam-like networks.

UI

@montekki montekki mentioned this pull request Nov 20, 2022
Open
10 tasks
@montekki montekki marked this pull request as ready for review October 4, 2022 09:45
@montekki
Copy link
Contributor Author

montekki commented Oct 4, 2022

Android UI

krodak
krodak approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@krodak krodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

android/src/main/java/io/parity/signer/components/IdentIcon.kt Show resolved Hide resolved
rust/db_handling/src/interface_signer.rs Outdated Show resolved Hide resolved
rust/definitions/src/helpers.rs Outdated Show resolved Hide resolved
@montekki
Copy link
Contributor Author

montekki commented Oct 4, 2022

TODO: the addrs have to be shown in eth format, not in ss58

prybalko
prybalko reviewed Oct 4, 2022
View reviewed changes
rust/parser/src/lib.rs Outdated Show resolved Hide resolved
@montekki montekki merged commit 0962d83 into master Oct 6, 2022
@montekki montekki deleted the fs-eth-keys branch October 6, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krodak krodak krodak approved these changes

@prybalko prybalko prybalko approved these changes

@Dmitry-Borodin Dmitry-Borodin Dmitry-Borodin approved these changes

@tetekinandrey tetekinandrey tetekinandrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@montekki @krodak @prybalko @Dmitry-Borodin @tetekinandrey