Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds README. #59

Merged
merged 14 commits into from Oct 4, 2019

Conversation

@RubyNova
Copy link
Member

commented Oct 3, 2019

This PR deals with the README portion of #45 .

This shouldn't take too long to review, but I'd like someone else to have a look.

@capnkenny

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Seems good for now - do you want some proofreading and/or nitpicks?

@RubyNova

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

Sure nitpick if you want I wrote it in 10 minutes lol.

README.md Outdated Show resolved Hide resolved
@capnkenny

This comment has been minimized.

Copy link
Member

commented on README.md in c10de91 Oct 3, 2019

nit: Perhaps you should elaborate, as first glance doesn't really explain the ink support. Maybe a Future Improvements section?

@tannergooding

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

nit: Merge #60 first and then add a link to the CoC

RubyNova added 5 commits Oct 3, 2019
Misc. merge for readme updates.
@tannergooding

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

nit: Also wait for #62 to be merged and add short blurb on the license to the readme.

@RubyNova

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

poking the bot

README.md Outdated Show resolved Hide resolved
RubyNova added 3 commits Oct 4, 2019
@RubyNova RubyNova merged commit 20b35ce into master Oct 4, 2019
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.