Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds MIT Licences. #62

Merged
merged 8 commits into from Oct 4, 2019

Conversation

@RubyNova
Copy link
Member

commented Oct 3, 2019

Resolves #43 .

@tannergooding

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

nit: Name this LICENSE.md, as that ensures GitHub has a friendly rendering for it.

LICENSE Outdated Show resolved Hide resolved
@tannergooding tannergooding referenced this pull request Oct 3, 2019
@tannergooding

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

nit: It is generally "best practice" to have a short comment at the top of all code files, calling out the license and referring back to the LICENSE.md

RubyNova added 3 commits Oct 3, 2019
@CLAassistant

This comment has been minimized.

Copy link

commented Oct 4, 2019

CLA assistant check
All committers have signed the CLA.

@RubyNova RubyNova merged commit 175691b into master Oct 4, 2019
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.