Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLAPI modularisation. #98

Merged
merged 75 commits into from Jan 8, 2020
Merged

LLAPI modularisation. #98

merged 75 commits into from Jan 8, 2020

Conversation

@RubyNova
Copy link
Member

RubyNova commented Dec 19, 2019

AB#61

This PR is the result of a discussion on discord surrounding the current LLAPI structure and how we want to handle object deletion. As a result this PR resolves #51 .

@RubyNova RubyNova force-pushed the feature/llapi-modularisation branch from ded6955 to 0f894ae Dec 21, 2019
CMakeLists.txt Outdated Show resolved Hide resolved
RubyNova added 8 commits Jan 3, 2020
…tate correctly. This probably isn't perfect but its catch-all, and some kind of message bus would probably be better.
RubyNova added 2 commits Jan 6, 2020
…ends. Deleted conditional typedef for AdvanceInteger.
…g an issue with the SDL2 window resize events. Resolves #104
src/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
set(NOVELRT_EXECUTABLE_HEADERS
${NOVELRT_HEADERS}
)

set(NOVELRT_EXECUTABLE_SOURCES

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jan 7, 2020

Contributor

Shouldn't this (and others) be moved to the respective projects rather than be in the root?

This comment has been minimized.

Copy link
@RubyNova

RubyNova Jan 7, 2020

Author Member

I think any remnants are Doxygen specific/have just not been cleaned out yet or I mistook them for shared settings such as set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON).

include(GNUInstallDirs)

set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/Modules/")
set(CMAKE_CXX_STANDARD 17)

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jan 7, 2020

Contributor

We should centralize and import several of these options, rather than having to redeclare them in each CMakeLists.txt

This comment has been minimized.

Copy link
@RubyNova

RubyNova Jan 7, 2020

Author Member

What would be the approach for doing this? Would we have another CMake file that contains these settings or?

samples/CMakeLists.txt Outdated Show resolved Hide resolved
@RubyNova RubyNova force-pushed the feature/llapi-modularisation branch from b438f7e to e5c9d36 Jan 8, 2020
@RubyNova RubyNova merged commit 31c8a50 into master Jan 8, 2020
6 checks passed
6 checks passed
license/cla Contributor License Agreement is signed.
Details
novelrt.novelrt-pr Build #20200108.5 succeeded
Details
novelrt.novelrt-pr (ubuntu_debug_x64) ubuntu_debug_x64 succeeded
Details
novelrt.novelrt-pr (ubuntu_release_x64) ubuntu_release_x64 succeeded
Details
novelrt.novelrt-pr (windows_debug_x64) windows_debug_x64 succeeded
Details
novelrt.novelrt-pr (windows_release_x64) windows_release_x64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.