-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code #74
Conversation
LICENSE.md
Outdated
@@ -1,7 +1,7 @@ | |||
Copyright (c) 2015 Yusuke Ito | |||
Copyright (c) 2015-17 Yusuke Ito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already 2018 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, Great. Thanks!
LGTM. Can you merge and release this as new 0.9.0 beta? I'll then test it with my setup. |
Thanks for feedbacks. I released this as |
|
||
} | ||
|
||
public struct QueryArray: QueryParameter, QueryArrayType { | ||
let arr: [QueryParameter?] | ||
@available(*, renamed: "QueryArray") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this not the correct usage of renamed
. This annotation should be on the old type and refer to the new name, see: https://developer.apple.com/library/content/documentation/Swift/Conceptual/Swift_Programming_Language/Attributes.html
@available(*, unavailable, renamed: "QueryParameterArray")
typealias QueryArray = QueryParameterArray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florianreinhart Oh, great! Thanks. I will fix that later.
No description provided.