Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ie11 and edge no enter/backspace #734

Closed
flumm opened this issue Dec 14, 2016 · 13 comments

Comments

Projects
None yet
5 participants
@flumm
Copy link
Contributor

commented Dec 14, 2016

with current master, when pressing enter or backspace (possibly other keys too) nothing happens
with debug level on i can see on the console

onKeyPress down, keysym: 16777226(16777226)
onKeyPress up, keysym: 16777226(16777226)

on /tests/input.html i get

raw key event keydown (key: 13, char 0, which: 13)
RFB keypress up keysym: [object Object] key name: [object Object]

what can be wrong here?

@flumm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2016

i found, that ie11 and edge send "\n" as char in the keyboardevent
which gets parsed as unicode and the keysym 0x100000a gets sent, but the enter gets not recognized

@samhed samhed added the bug label Dec 22, 2016

@samhed

This comment has been minimized.

Copy link
Member

commented Dec 22, 2016

I can somewhat reproduce your problem. When running xev in a session and pressing backspace or enter I get the same wierd 0x100000a keysyms. However, both keys work as expected when actually using them for typing etc.

@CendioOssman

This comment has been minimized.

Copy link
Member

commented Dec 22, 2016

A lot of applications will expect the proper keysym though.

@flumm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 22, 2016

I can somewhat reproduce your problem. When running xev in a session and pressing backspace or enter I get the same wierd 0x100000a keysyms. However, both keys work as expected when actually using them for typing etc.

what kind of vnc server do you use? i use the qemu builtin one, which does not work (qemu 2.7)

edit: also i want to mention that the vm i run is also a windows vm, so that might also be a factor

@samhed

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

I used TigerVNC

@DirectXMan12 DirectXMan12 added this to the v0.7.0 milestone Jan 6, 2017

@samhed

This comment has been minimized.

Copy link
Member

commented Jan 9, 2017

This is a regression from commit 115eedf

@zoon01

This comment has been minimized.

Copy link

commented Jan 14, 2017

With latest release the problem still exist.
No Enter or Backspace keys working.

Windows 10 with IE11 connecting a freebsd 11 VM with virtualbox and LibVNCServer-0.9.9
The browser chrome does work correctly.

@samhed samhed added the regression label Jan 20, 2017

@CendioOssman

This comment has been minimized.

Copy link
Member

commented Jan 20, 2017

This is a regression from commit 115eedf

I reverted it and the problem still remains (albeit slightly different), so it's not that.

IE/Edge is setting char for its keydown events which is confusing our code. Will need to have a deeper look.

@flumm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2017

are you sure?

in my local branch i reverted that commit, and it works fine since...

@CendioOssman

This comment has been minimized.

Copy link
Member

commented Jan 20, 2017

Perhaps not. I think I only got a revert on one of the files. Will have to look at it next week.

@zoon01

This comment has been minimized.

Copy link

commented Feb 10, 2017

Where are we standing now? Is the problem already fixed in master?

@samhed

This comment has been minimized.

Copy link
Member

commented Feb 10, 2017

@zoon01 not fixed in master, but #766 fixes this at least for me.

@CendioOssman

This comment has been minimized.

Copy link
Member

commented May 4, 2017

#766 is merged so this is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.