Wear configuration demo #24

danybony · 2016-12-07T11:52:21Z

This PR adds a demo build config needed to add a Wear module to an existing project.
This demo shows how to integrate Wear with some real-world scenario like

multi-dimensions flavours
support for alternative markets (without PlayServices)
different signing keys for different build types

mr-archano · 2016-12-07T13:04:20Z

WearBuildConfig/mobile/build.gradle

+        }
+
+        qaRelease.initWith(buildTypes.release)
+        qaRelease {


maybe just qa? I wonder if this will break the smart task abbreviation because of the clashing with release 😕

Good idea for simplify to just qa

mr-archano · 2016-12-07T13:08:44Z

LeftNavBarExample/LeftNavBarLibrary/build.gradle

@@ -3,7 +3,7 @@ buildscript {
        jcenter()
    }
    dependencies {
-        classpath 'com.android.tools.build:gradle:1.0.0'
+        classpath 'com.android.tools.build:gradle:2.2.1'


why these changes to other modules? I see we have a root multi-module project, but what's the value of it? ideally all these demos should be separated project, right?
If anything we should consider to extract this common dependency (or at least the version) in a single place where it will be easier to maintain

Regarding the changes, these were done automatically by the IDE, i just thought there was no harm in updating in other modules too.

Regarding the multi-module, I can see it useful to reduce duplication of the gradle wrapper for example, and also the fact that it's easier to load it immediately from the root, having access to all the projects.

This is just my point of view, I don't remember the historical reasons behind this repo structure honestly.

My considerations comes from the realisation every module is an app on its own. I see the plus of the simpler import, but that means also longer evaluation times (the whole root project is evaluated in the process 😅 ). I'm not saying you should change the rest of the projects, but I would seriously consider not to follow the (broken IMHO) pattern and make this a separate project on its own (all you need is avoid to list your module in the root settings.gradle, right?).

Yes, I see your point.
Honestly I don't mind having this one as an independent project, but that would require a duplication of the gradle wrapper or can we avoid that somehow?

Nah, duplication of the wrapper can't be avoided, but I really don't feel is like a big deal 😸 Actually this is a good opportunity to use Gradle 3.x. in your own isolated and cohesive project. Mmm 🤔 sounds even better to me.

Ok, followed your suggestion @mr-archano and moved this demo into a independent project: dec78a2

Why not updating to 2.2.3 while we're on it? 2.2.1 wasn't the latest even 15 days ago :D

¯_(ツ)_/¯ it was not the main point of this PR

mr-archano · 2016-12-07T13:10:00Z

WearBuildConfig/mobile/build.gradle

@@ -0,0 +1,71 @@
+apply plugin: 'com.android.application'
+apply from: "$rootProject.projectDir/WearBuildConfig/shared-config/android-signing.gradle"


this could be a more idiomatic rootProject.file('WearBuildConfig/shared-config/android-signing.gradle')

Done in 3f4cf8d

mr-archano · 2016-12-07T13:12:11Z

WearBuildConfig/mobile/build.gradle

+        versionCode 1
+        versionName "1.0"
+
+        buildConfigField 'boolean', 'PLAY_SERVICES', "true"


if you're seeking a good example of a build.gradle you could consider the use of the gradle-build-properties-plugin and its typed decorators for buildConfigField

Thanks for the hint, but this field is just an example of a value set differently in the two variations of the flavour dimension.
I'd prefer to keep it as simple as possible, without adding external plugins in this demo

mr-archano · 2016-12-07T13:13:34Z

WearBuildConfig/mobile/build.gradle

+            //uses default PLAY_SERVICES value
+        }
+
+        preProduction {


what is preProduction? maybe development as environment would be easier to grasp

In this project is to show an example of second flavour dimension: the environment.
Agree, development could be easier to understand

Done in 042ae78

mr-archano · 2016-12-07T13:16:12Z

WearBuildConfig/mobile/build.gradle

+}
+
+dependencies {
+    productionPlayServicesReleaseWearApp project(path: ':WearBuildConfigWear', configuration: 'productionRelease')


I'm lost. Above you defined 4 additional configurations, but they've not be used anywhere else, right? Maybe this is material for the (missing) README

These configurations are used under the hood by gradle to copy the Wear APK into the mobile APK's res/raw folder.
This is done ONLY for the configurations here defined, so for example it doesn't happen for noPlayServices builds.
Good point on the readme, I'll write one when I'm back

mr-archano · 2016-12-07T13:19:29Z

settings.gradle

@@ -26,3 +26,7 @@ include 'TabHostExample'
 include 'TabHostSelfContainedTabBrowsing'
 include 'wizard'
 include 'EditTextChips'
+include 'WearBuildConfigMobile'
+project(':WearBuildConfigMobile').projectDir = new File('WearBuildConfig/mobile')


ok, I think I see what you're trying to do, but I'm still not sure why you need to create this alias (and the one below). If you're trying to workaround the multi module setup in the whole android-demos maybe this is not the best solution. clarifying your intent here would help a lot :)

What I'm trying to do is to create two modules that share the same parent in the main project root:

WearBuildConfig/mobile

WearBuildConfig/wear

Can you specify what's wrong with this way of doing it?
This is the same strategy it was used for other modules here and I'll be curious to hear about alternatives (even if we might make this project independent)

Sorry I wasn't clear enough: read my comment above as something in line with the suggestion of make this module a self-contained project. It's not wrong, it follows what's already in place, but I personally think it's a flawed approach that we should address soon.

xrigau

💯 nice one @danybony !

rock3r

LGTM, just wondering why we've upgraded to old tools versions instead of the latest, but can ship as-is

rock3r · 2016-12-22T08:51:00Z

LeftNavBarExample/LeftNavBarLibrary/build.gradle

@@ -3,7 +3,7 @@ buildscript {
        jcenter()
    }
    dependencies {
-        classpath 'com.android.tools.build:gradle:1.0.0'
+        classpath 'com.android.tools.build:gradle:2.2.1'


Why not updating to 2.2.3 while we're on it? 2.2.1 wasn't the latest even 15 days ago :D

rock3r · 2016-12-22T08:53:02Z

WearBuildConfig/gradle/wrapper/gradle-wrapper.properties

+distributionPath=wrapper/dists
+zipStoreBase=GRADLE_USER_HOME
+zipStorePath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-3.0-all.zip


Y U NO 3.2.1?

rock3r · 2016-12-22T09:00:53Z

WearBuildConfig/wear/build.gradle

+
+android {
+    compileSdkVersion 25
+    buildToolsVersion "25.0.0"


Why not 25.0.1 while we're at it?

danybony added 6 commits December 6, 2016 15:36

Update gradle build tools

3c28931

Create minimum required modules for wear

aeb420e

Add multi-dimensions flavors

77ae77e

Add shared signing config

50683b0

Enable Wear bundling for QaRelease builds

4fb1e7a

Add watch demo activity

4bb043c

mr-archano reviewed Dec 7, 2016

View reviewed changes

danybony added 6 commits December 7, 2016 16:01

Rename preProduction to development

042ae78

Rename qaRelease with qa

6f52498

Use rootProject.file() for signing config loading

3f4cf8d

Make WearBuildConfig an independent project

dec78a2

Update gradle version for WearBuildConfig demo

4fe9e8b

Create README for WearBuildConfig

964a805

mr-archano approved these changes Dec 13, 2016

View reviewed changes

rock3r assigned rock3r and mr-archano Dec 22, 2016

rock3r self-requested a review December 22, 2016 08:49

xrigau approved these changes Dec 22, 2016

View reviewed changes

xrigau merged commit 6b55290 into master Dec 22, 2016

xrigau deleted the wear_config branch December 22, 2016 08:50

rock3r reviewed Dec 22, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wear configuration demo #24

Wear configuration demo #24

danybony commented Dec 7, 2016

mr-archano Dec 7, 2016

danybony Dec 7, 2016

danybony Dec 7, 2016

mr-archano Dec 7, 2016

danybony Dec 7, 2016

mr-archano Dec 7, 2016 •

edited

danybony Dec 7, 2016

mr-archano Dec 7, 2016

danybony Dec 12, 2016

rock3r Dec 22, 2016

danybony Dec 22, 2016

mr-archano Dec 7, 2016

danybony Dec 7, 2016

mr-archano Dec 7, 2016

danybony Dec 13, 2016

mr-archano Dec 7, 2016

danybony Dec 7, 2016

danybony Dec 7, 2016

mr-archano Dec 7, 2016

danybony Dec 7, 2016

mr-archano Dec 7, 2016

danybony Dec 7, 2016

mr-archano Dec 8, 2016

xrigau left a comment

rock3r left a comment

rock3r Dec 22, 2016

rock3r Dec 22, 2016

rock3r Dec 22, 2016

		@@ -0,0 +1,71 @@
		apply plugin: 'com.android.application'
		apply from: "$rootProject.projectDir/WearBuildConfig/shared-config/android-signing.gradle"

Wear configuration demo #24

Wear configuration demo #24

Conversation

danybony commented Dec 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mr-archano Dec 7, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xrigau left a comment

Choose a reason for hiding this comment

rock3r left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mr-archano Dec 7, 2016 •

edited