New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asynchronously added variants #160

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
4 participants
@passsy
Contributor

passsy commented Jan 5, 2018

all should be used because variants may not be available at that time when .forEach is call. all will also be called for each variant which will added later. This means here is a race condition on some machines not adding the required tasks.

see StefMa/AndroidArtifacts#9

From the documentation:
https://docs.gradle.org/current/javadoc/org/gradle/api/DomainObjectCollection.html#all(groovy.lang.Closure)
Executes the given action against all objects in this collection, and any objects subsequently added to this collection.

"subsequently added" variants where ignored until now.

fixes #96

Fix asynchronously added variants
`all` should be used because variants may not be available at that time when `.forEach` is call. `all` will also be called for each variant which will added later. This means here is a race condition on some machines not adding the required tasks.

see StefMa/AndroidArtifacts#9

From the documentation:
https://docs.gradle.org/current/javadoc/org/gradle/api/DomainObjectCollection.html#all(groovy.lang.Closure)
Executes the given action against all objects in this collection, and any objects subsequently added to this collection.

"subsequently added" variants where ignored until now.

fixes  #96
@hal9002

This comment has been minimized.

Show comment
Hide comment
@hal9002

hal9002 Jan 5, 2018

Can one of the admins review this PR?

hal9002 commented Jan 5, 2018

Can one of the admins review this PR?

@StefMa

This comment has been minimized.

Show comment
Hide comment
@StefMa

StefMa Jan 8, 2018

Contributor

ok to test

Contributor

StefMa commented Jan 8, 2018

ok to test

@StefMa

StefMa approved these changes Jan 8, 2018

LGTM 👍

@StefMa

This comment has been minimized.

Show comment
Hide comment
@StefMa

StefMa Jan 8, 2018

Contributor

Can a admin look why it's hanging?!

Contributor

StefMa commented Jan 8, 2018

Can a admin look why it's hanging?!

@ataulm

This comment has been minimized.

Show comment
Hide comment
@ataulm

ataulm Jan 8, 2018

Contributor

ok to test

Contributor

ataulm commented Jan 8, 2018

ok to test

@ataulm

This comment has been minimized.

Show comment
Hide comment
@ataulm

ataulm Jan 8, 2018

Contributor

yeah not really sure what's going on here

image

there's no queued builds on the CI 🤔

Contributor

ataulm commented Jan 8, 2018

yeah not really sure what's going on here

image

there's no queued builds on the CI 🤔

@ataulm ataulm merged commit c98020e into novoda:master Jan 8, 2018

1 of 2 checks passed

Jenkins CI CI build queued
Details
default Build succeeded
Details

@passsy passsy deleted the passsy:patch-1 branch Jan 9, 2018

@StefMa StefMa referenced this pull request Jan 26, 2018

Closed

pom.xml not generated #134

@mr-archano mr-archano referenced this pull request Mar 26, 2018

Merged

Prepare release 0.8.1 #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment