Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save button for digest #1172

Merged
merged 5 commits into from Sep 25, 2022
Merged

Add save button for digest #1172

merged 5 commits into from Sep 25, 2022

Conversation

Wyfy0107
Copy link
Contributor

@Wyfy0107 Wyfy0107 commented Aug 31, 2022

  • What kind of change does this PR introduce?
    Add save button for digest

  • What is the current behavior?
    [NV-831] - Add a save buton to digest #1151
    The current form of digest does not have a save button, which is bad UX

  • What is the new behavior (if this is a feature change)?
    Now with a save button, user can save after editing digest properties

  • Other information:

@scopsy
Copy link
Contributor

scopsy commented Sep 4, 2022

Thank you so much for you contribution @Wyfy0107! A small question does the button right now submits the entire form of notification template? If so, can we just submit or persist the changes related to the digest section? Even if we just hide the side bar for the user without doing anything. Just logically it feels more sense for the user to have this button available for him.

What do you think about that approach?

P.S
Could you please add a screen shot of how the button visually looks it will help a lot 🎉

@Wyfy0107
Copy link
Contributor Author

Wyfy0107 commented Sep 6, 2022

Thank you so much for you contribution @Wyfy0107! A small question does the button right now submits the entire form of notification template? If so, can we just submit or persist the changes related to the digest section? Even if we just hide the side bar for the user without doing anything. Just logically it feels more sense for the user to have this button available for him.

What do you think about that approach?

P.S Could you please add a screen shot of how the button visually looks it will help a lot 🎉

Yes it will submit the entire form currently. I agree it would make more sense to just save digest related data. I will update it.
Here's the picture currently

Screenshot 2022-08-31 at 23 28 29

@BiswaViraj BiswaViraj linked an issue Sep 7, 2022 that may be closed by this pull request
@Wyfy0107
Copy link
Contributor Author

Wyfy0107 commented Sep 21, 2022

@scopsy It looks like there's no dedicated api endpoint for digest as it's a step of notification template. So I guess I will just hide the form for now

@scopsy
Copy link
Contributor

scopsy commented Sep 23, 2022

Yes @Wyfy0107 exactly, it's just a UI hide functionality 🚀

@scopsy scopsy merged commit c451ea3 into novuhq:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-831] - Add a save buton to digest
2 participants