Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - Punjabi Support #1402

Merged
merged 2 commits into from Oct 4, 2022
Merged

i18n - Punjabi Support #1402

merged 2 commits into from Oct 4, 2022

Conversation

ArmanChand
Copy link
Contributor

What kind of change does this PR introduce?
This PR adds Punjabi Language support for Novu.

Why this change was needed? (You can also link to an open issue here)
This PR fixes #1374

@ArmanChand
Copy link
Contributor Author

@scopsy @davidsoderberg @ainouzgali Please review and approve. Also, please add the hacktoberfest-accepted label once it is approved. Thanks.

@ArmanChand
Copy link
Contributor Author

@scopsy @davidsoderberg @ainouzgali Please review and approve. Also, please add the hacktoberfest-accepted label once it is approved. Thanks.

@ArmanChand
Copy link
Contributor Author

@scopsy @davidsoderberg @ainouzgali please merge it

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@davidsoderberg
Copy link
Contributor

@ArmanChand please fix the conflicts :)

@ArmanChand
Copy link
Contributor Author

@davidsoderberg , i dont find any merge conflicts. Please take a look and merge

@p-fernandez
Copy link
Contributor

@davidsoderberg , i dont find any merge conflicts. Please take a look and merge

I fixed them on your behalf.

@p-fernandez p-fernandez merged commit 15682e2 into novuhq:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n - Punjabi Support
3 participants