Implements clickatell sms provider #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Abobos
changed the title
jainpawan21
reviewed
Aug 11, 2022
providers/clickatell/test.ts
Outdated
| import { ClickatellSmsProvider } from './src/index'; | ||
|
|
||
| const provider = new ClickatellSmsProvider({ | ||
| apiKey: 'otbjTKxDRlGxGlA6wiSCKQ==', |
There was a problem hiding this comment.
I think you exposed your key by mistake
There was a problem hiding this comment.
@jainpawan21 this has been removed. It was a file I used for testing the functionality
|
@Abobos is attempting to deploy a commit to the Novu Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @Abobos @jainpawan21 what's preventing this PR from being merged? |
It needs review cc : @scopsy |
github-actions
bot
added
@novu/api
@novu/web
documentation
This reverts commit bc48b8d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature (closes Add Clickatell SMS provider #604)
What is the current behavior? (You can also link to an open issue here)
Currently, we don't implement Clickatell provider for the SMS channel
What is the new behavior (if this is a feature change)?
Avail Clickatell SMS Provider