Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multibarchart] when the interactive layer is on, displays highlights #1678

Closed

Conversation

bobylito
Copy link

When using the interactive layer on multibarchart, there was no highlight of the hovered series. This behavior is inconsistent with the one from the stackedAreaChart and the lineChart.

I added a sample that let you test the behaviour. Unfortunately I was unable to implement tests for this new behavior. Could anyone give me a hand on that?

When using the interactive layer on multibarchart, there was no
highlight of the hovered series. This behavior is inconsistent with the
one from the stackedAreaChart and the lineChart.
@bobylito
Copy link
Author

bobylito commented Jul 5, 2016

Can I help make this PR go through?

if(isStacked && yValue >= d.data.y0 && yValue < d.data.y1)
allData[currentIdx].highlight = true;
else if(!isStacked && yValue >= 0 && yValue < d.data.y)
allData[currentIdx].highlight = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use brackets around all if/else blocks.

@liquidpele
Copy link
Contributor

This should really be done to multiBarHorizontalChart too so that they match.

@bobylito
Copy link
Author

bobylito commented Sep 7, 2016

Thanks @liquidpele for taking the time to have a look at this PR. Will make the necessary changes.

@liquidpele
Copy link
Contributor

ping...

@liquidpele
Copy link
Contributor

Closing this PR as abandoned...

@liquidpele liquidpele closed this Jan 8, 2017
@bobylito
Copy link
Author

bobylito commented Jan 9, 2017

Sorry @liquidpele bad timing for me :(

@liquidpele
Copy link
Contributor

No worries, par for the course with open source. Hey that rhymes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants