Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer #442

Closed
wants to merge 245 commits into
base: development
from

Conversation

Projects
None yet
@DavidSouther
Copy link
Contributor

DavidSouther commented Feb 10, 2014

This is not ready to merge

As we've been talking internally at Novus for a couple months, we want to pull out the boilerplate code from many of the charts and impose a sane OO model on top. Some of this work is predicated on the ideas from http://davidsouther.com/2013/02/readable-d3/.

Short-term, I'm pulling out the repeated boilerplate code (margins, size, d3 wrap, axis). Mid-term, this will be a new internal architecture, with the same API. Long term, we should be able to make the entire library much more extensible and readable.

Testing

From both branches (#development and #canvas), start a webserver in the root directory (python -m SimpleHTTPServer). Open a browser to the test/ directories. Compare visually (simple refresh on save is fine).

@comboy

This comment has been minimized.

Copy link

comboy commented Feb 11, 2014

hell yes, this has been due for some time, we're finally getting some sane charting library 👍

@robinfhu

This comment has been minimized.

Copy link
Member

robinfhu commented Feb 14, 2014

This is a great idea. There's currently too much duplicated code related to legend, axes, margin, and other common chart options.

@jgrund

This comment has been minimized.

Copy link
Contributor

jgrund commented Feb 25, 2014

Awesome 👍

@DavidSouther DavidSouther referenced this pull request May 11, 2014

Closed

Refactor/2.0.0 dev #537

@seiyria

This comment has been minimized.

Copy link

seiyria commented Jun 10, 2014

How soon would you guys think the documentation and new version will be ready to go? I see a lot of progress but I'm not sure when the end will come.

@arunkjn

This comment has been minimized.

Copy link

arunkjn commented Sep 15, 2014

Hi, any updates on the current status of the branch

@BrutalBrutus

This comment has been minimized.

Copy link

BrutalBrutus commented Sep 16, 2014

Hello all. I'm working on a prototype and using Angular and D3 and NVD3. I have what appears to be a simple obstacle. Does anyone here post and/or answer NVD3 questions here or on Stackoverflow? I need another set of eyes to help illuminate and de-cloud my brain. Cool stuff; just a little overwhelmed.

@DavidSouther

This comment has been minimized.

Copy link
Contributor Author

DavidSouther commented Sep 16, 2014

Yeah; post it on SO and share the link. Probably open a new issue, and tag
me in it.


David Souther
http://davidsouther.com
(406) 545-9223

On Tue, Sep 16, 2014 at 12:22 PM, Brutal Brutus notifications@github.com
wrote:

Hello all. I'm working on a prototype and using Angular and D3 and NVD3. I
have what appears to be a simple obstacle. Does anyone here post and/or
answer NVD3 questions here or on Stackoverflow? I need another set of eyes
to help illuminate and de-cloud my brain. Cool stuff; just a little
overwhelmed.


Reply to this email directly or view it on GitHub
#442 (comment).

@arunkjn

This comment has been minimized.

Copy link

arunkjn commented Sep 29, 2014

Hi @DavidSouther, is there any major work left in this branch? what would it take to get this into master?

@englercj

This comment has been minimized.

Copy link

englercj commented on d6c40a6 Oct 2, 2014

FYI, this commit removed nv.d3.js (it is basically empty now) not sure if that was on purpose.

@liquidpele

This comment has been minimized.

Copy link
Contributor

liquidpele commented Feb 17, 2015

This is stale and way too big of a pull request anyway... closing.

@liquidpele liquidpele closed this Feb 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.