Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gist.js to handle HTML undefined #33

Merged
merged 1 commit into from Dec 31, 2019
Merged

Fix Gist.js to handle HTML undefined #33

merged 1 commit into from Dec 31, 2019

Conversation

@justinyoo
Copy link
Contributor

justinyoo commented Dec 30, 2019

This is the PR for gist embed.

I got this error when I run my gridsome app.

image

To fix this issue, this StackOverflow article suggests using this trick:

html == undefined ? '' : html.trim()

Therefore, I updated our Gist.js with the trick above and it worked fine (on my machine of course 馃槒). It would be great if you can have a look and merge it.

Cheers,

@noxify noxify merged commit 65ccc49 into noxify:master Dec 31, 2019
@noxify

This comment has been minimized.

Copy link
Owner

noxify commented Dec 31, 2019

thanks @justinyoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.