Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript definitions for Routes & add withRouteData & withSiteData #1174

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
5 participants
@bwallberg
Copy link
Contributor

commented May 6, 2019

Description

Updated index.d.ts so that you can compile the react-static typescript template when using specific parts of the API.

Changes/Tasks

  • Fixed invalid typescript definitions for Routes ( it's actually not for Routes but is rather hijacked by @reach/router, but that's just how it works it seems...).

  • Added missing typescript definitions for withRouteData & withSiteData

  • Changed code

Motivation and Context

Fix broken typescript definitions

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the documentation accordingly
  • I have updated the CHANGELOG with a summary of my changes
  • My changes have tests around them
@sw-yx

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

i swear i PR'ed this before but something went wrong. thank you!

@sw-yx sw-yx merged commit 045a0e1 into nozzle:master May 7, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
deploy/netlify Deploy preview ready!
Details
@julesce

This comment has been minimized.

Copy link

commented May 9, 2019

Thanks for hooking up this fix! Just for planning purposes, is there a rough date in mind for the next versioned release?

@sw-yx

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

@tannerlinsley

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Maybe someone should set up automated releases ;)

@tannerlinsley

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

I'm supes busy right now, but I'll try and find some time to go through things soon.

@jaridmargolin

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Would be great to see this land in a release 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.