Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-static-plugin-stylus #1213

Merged
merged 3 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@JonDum
Copy link
Contributor

commented Jun 4, 2019

Description

Adds a plugin for loading stylus .styl files.

Changes

  • Adds stylus plugin

Motivation and Context

Because I prefer Stylus and there wasn't one yet.

Screenshots (if appropriate):

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the documentation accordingly
  • I have updated the CHANGELOG with a summary of my changes
  • My changes have tests around them
@JonDum

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

This is basically copy pasted from the less/sass loaders with two distinctions.

  1. I added a cssLoaderOptions that spreads over to the css-loader options. This might even be a good standard to add to the other css plugins as it allows more flexibility to users.

  2. I use ExtractCssChunks in both dev and prod. On my team we've had a few nasty surprises going from dev to prod when we used to have style-loader only for dev. Turns out that you can have some odd css selector specificity issues going from <style> tags to <link> style sheets. We found it's better to just use ExtractCssChunks in both dev and prod to make the environments as similar as possible.

@tannerlinsley tannerlinsley merged commit 0e07a42 into nozzle:master Jun 7, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
deploy/netlify Deploy preview ready!
Details
@tannerlinsley

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Just make sure that the react-static-plugin-stylus package name is available, or that tannerlinsley is added as an admin on it and this will get published with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.