Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getting started sample async #20

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@roji
Copy link
Member

roji commented Oct 14, 2019

No description provided.

conceptual/Npgsql/index.md Outdated Show resolved Hide resolved
using (var cmd = new NpgsqlCommand("SELECT some_field FROM data", conn))
using (var reader = cmd.ExecuteReader())
while (reader.Read())
using (var reader = await cmd.ExecuteReaderAsync())
Comment on lines 33 to 34

This comment has been minimized.

Copy link
@YohDeadfall

YohDeadfall Oct 14, 2019

Member

And two more here, what do you think?

@roji roji force-pushed the AsyncGettingStarted branch from 7d6fd76 to 5177351 Oct 14, 2019
@roji

This comment has been minimized.

Copy link
Member Author

roji commented Oct 14, 2019

Also changed to use the new C# 8 using declarations.

It may be a bit too modern for most users, but they'll get used to it quickly enough :)

@roji roji merged commit 54bb0aa into master Oct 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the AsyncGettingStarted branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.