-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ThrowHelper instead of inline exception throwing #2237
Comments
Just to clarify, are you expecting this issue to cover all exceptions thrown in npgsql, everywhere? |
As the starting point it should be done for hot paths (connections, commands, handlers). After that we could consider about other parts of the project. |
Thanks for reminding me about this. If we really want to prevent duplication of exception messages, it seems like that can/should be done with a standard "Strings" (i.e. resx). At least in theory it would also allow localization down the road (although I'm not too enthusiastic about that). For the perf side:
Maybe set up a quick benchmark to see if it still makes sense? |
@YohDeadfall do you still intend to do this for 5.0? If not, can we please move this to the backlog (or 6.0)? |
@YohDeadfall I'm going to move this out to vNext. If you get around to doing this for 5.0 we can always move it back. |
Am fine with it. |
The idea of the proposed change is to:
Prevent duplication of exception messages.The text was updated successfully, but these errors were encountered: