New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ThrowHelper instead of inline exception throwing #2237

Open
YohDeadfall opened this Issue Nov 21, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@YohDeadfall
Member

YohDeadfall commented Nov 21, 2018

The idea of the proposed change is to:

  1. Make code generated methods smaller because the JIT emits jump to throw methods and doesn't inline them. The description of the trick can be found here.
  2. Prevent duplication of exception messages.

@YohDeadfall YohDeadfall added this to the 4.1 milestone Nov 21, 2018

@roji

This comment has been minimized.

Member

roji commented Nov 21, 2018

Just to clarify, are you expecting this issue to cover all exceptions thrown in npgsql, everywhere?

@YohDeadfall

This comment has been minimized.

Member

YohDeadfall commented Nov 22, 2018

As the starting point it should be done for hot paths (connections, commands, handlers). After that we could consider about other parts of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment